Support iOS 26 Liquid Glass: Document and handle tint color and button style changes#284
Merged
Merged
Conversation
…nd dismiss button style - Updated SFSafariViewController factory to avoid setting `preferredBarTintColor` and `preferredControlTintColor` on iOS 26 and later, as these properties are deprecated. - Adjusted tests to account for iOS 26 changes: checks for `dismissButtonStyle` and tint colors now use version checks.
… are ignored on iOS 26 and later - Clarified in `SafariViewControllerOptions` that these properties have no effect on iOS 26+ due to the introduction of Liquid Glass. - Added notes to `LaunchOptions` indicating that `barColor` and `onBarColor` have no effect on iOS 26+ because of the Liquid Glass UI change. - Added links to the relevant Apple documentation for both properties.
…itations - Clarified in the feature matrix that background and control color options are ignored on iOS 26 and later. - Added a new section explaining the impact of Liquid Glass on `SafariViewControllerOptions` and the deprecation of tint color properties. - Provided a link to Apple's official documentation for further reference.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to support iOS 18's Liquid Glass feature by documenting and handling tint color deprecations and button style changes in Safari View Controller.
Key changes:
- Documents that
preferredBarTintColorandpreferredControlTintColorare ignored on iOS 18+ due to Liquid Glass - Adds iOS version checks to skip setting deprecated tint colors on iOS 18+
- Updates tests to account for default dismiss button style change from
.doneto.closeon iOS 18+
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
flutter_custom_tabs_ios/lib/src/types/safari_view_controller_options.dart |
Added documentation notes about Liquid Glass behavior for tint color properties |
flutter_custom_tabs_ios/ios/flutter_custom_tabs_ios/Sources/flutter_custom_tabs_ios/SFSafariViewController+Factory.swift |
Added iOS version check to skip setting tint colors on iOS 18+ |
flutter_custom_tabs_ios/example/ios/RunnerTests/SFSafariViewController+FactoryTest.swift |
Updated tests to verify tint colors are nil on iOS 18+ and dismiss button style changes |
flutter_custom_tabs_ios/example/ios/RunnerTests/MockLauncher.swift |
Added UIKit import for explicit type reference |
flutter_custom_tabs/lib/src/lite/launch_options.dart |
Added Liquid Glass documentation notes to lite API options |
flutter_custom_tabs/README.md |
Added Liquid Glass section and updated customization table with iOS version notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.