Drop dependabot configuration#38
Open
JamiKettunen wants to merge 20 commits intodroidian:droidianfrom
Open
Conversation
Author
|
@bellegarde-c Ping |
JamiKettunen
force-pushed
the
rm-dependabot
branch
from
67f7de2 to
fc76967
Compare
Really slow on a phone, this commit does not really fix the issue :(
…obile When entering a conversation, signal-quill-cjs automatically focuses the editor, triggering the on-screen keyboard on mobile devices. This behavior is undesirable, as it suggests immediate typing is required. To prevent this: - The editor is now initially rendered with the inert attribute, making it non-focusable and non-interactive. - The inert attribute is removed on user click, allowing interaction and manual focus. This improves the user experience on mobile by preventing the keyboard from appearing until explicitly needed.
Subscribe to the `ActiveChanged` signal from `org.gnome.ScreenSaver` via DBus and maintain internal state to reflect screensaver activity. The `isActive()` method now returns `false` when the screensaver is active, ensuring that application logic properly respects user inactivity. Useful for improving notifications behavior when the user is away. Only GNOME is supported at this stage; other desktop environments could be added later.
…andling When Signal is minimized to the system tray, launching a second instance causes Electron to go through a full startup cycle before signaling the main instance to show the window. This results in a noticeable delay (~2 seconds). To avoid this, a lightweight D-Bus interface (`org.signal.Signal`) has been added. It exposes a `ShowWindow` method to allow the window to be shown immediately without full app startup. A wrapper script (`signal-desktop-mobile`) now attempts to call this method via `gdbus`. If the main instance is not running, it falls back to launching a new Electron process. This approach significantly reduces perceived startup time when the app is already running but hidden.
Signal currently disables notifications on reconnect until the message queues are fully processed. While this behavior prevents notification floods on a fresh start, it causes problems in our use case where freeze/unfreeze cycles can lead to missed messages. By removing notificationService.disable() call on socket connect, we ensure notifications remain active throughout reconnects, preventing silent message losses caused by paused queues. This change prioritizes message delivery and user awareness over suppressing notification floods during reconnect.
…e reset is avoided when touching outside of the rectangle
GNOME Shell needs it.
This just keeps causing pointless noise in PRs while updates are merged from upstream anyway where this bot originates from.
JamiKettunen
force-pushed
the
rm-dependabot
branch
from
fc76967 to
eb31bd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just keeps causing pointless noise in PRs (just look at https://github.com/droidian/Signal-Desktop/pulls?q=is:pr+is:closed) while updates are merged from upstream anyway where this bot originates from (e.g. be7a889).