Fix drone-runner-docker deployment port name#114
Open
sfleener wants to merge 2 commits intodrone:masterfrom
Open
Fix drone-runner-docker deployment port name#114sfleener wants to merge 2 commits intodrone:masterfrom
sfleener wants to merge 2 commits intodrone:masterfrom
Conversation
Contributor
|
Thanks for the contribution @sfleener Currently the pipeline requires the version to be set in Chart.yaml. Can you bump the version to 0.6.2 in your branch? Thanks |
Author
|
Bumped the version, the lint should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoints aren't properly assigned when the port name in the deployment doesn't match the port name in the service (more context). The port names for the server chart match but not for the docker runner, so this updates the docker runner deployment to use the same name as the service.