service account support for drone server#76
Merged
jimsheldon merged 2 commits intodrone:masterfrom Jun 24, 2022
Merged
Conversation
|
Hi Drone team. Any progress on this one? That would be great to have that implemented |
Contributor
|
Apologies for the delay. Thank you for the contribution! |
Contributor
Author
|
Thanks! Let me know if any issues come up (we did test it on our cluster so hopefully not) and I can fix it. |
Contributor
Author
|
@jimsheldon do you think you can publish this on Monday? @ShelRoman this is why our deployment is failing --^ |
Contributor
|
@bkk-bcd I think you just need to run |
Contributor
Author
Ah geeze you are right. Think I've been spoiled by ArgoCD a bit to much! Sorry to be a bother, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix for #31
Allows service accounts to be created/managed by helm for drone in the usual fashion. Code copied directly from
helm createwith the exception of the requireddrone.serviceAccountNamehelper which was already defined.Schema update copied from
drone-runner-docker.Left
automountServiceAccountTokenas is (https://github.com/drone/charts/pull/76/files#diff-085c19ead4ddab83dba353448d341f2781cbb60599e04b9a36da2a50b2f681e7R29)