ui: Migrate CheckBoxes to use binary state functions setChecked/isChecked#121
Merged
tridge merged 1 commit intoMar 29, 2026
Merged
Conversation
…cked Various points in the code make use of Tri-state functionality (ie. setCheckedState()/checkedState()). In working to migrate the tool to PyQt6, the checkedState() returns and enum, and the enum CheckedState.Unchecked is not considered Falsy. What that means is `if chkbox.checkState()` always returns True. The checkState functionality allows us to make use of a PartiallyChecked state, which is never used inside the codebase - so let's just use the binary states.
tridge
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various points in the code make use of Tri-state functionality (ie. setCheckState()/checkState()).
In working to migrate the tool to PyQt6, the checkState() returns and enum, and the enum CheckedState.Unchecked is not considered Falsy.
What that means is
if chkbox.checkState()always returns True.The checkState functionality allows us to make use of a PartiallyChecked state, which is never used inside the codebase - so let's just use the binary states.
This differs from PyQt5 where:
Needed to resolve Issue #107