Skip to content

add macos CI build#122

Merged
tridge merged 1 commit into
dronecan:masterfrom
Huibean:pr-add-macos-ci-build
Mar 29, 2026
Merged

add macos CI build#122
tridge merged 1 commit into
dronecan:masterfrom
Huibean:pr-add-macos-ci-build

Conversation

@Huibean

@Huibean Huibean commented Mar 29, 2026

Copy link
Copy Markdown
Member
  • add macos CI build .dmg

Copilot AI review requested due to automatic review settings March 29, 2026 03:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds macOS CI support to build a distributable .app bundle and package it into a .dmg artifact for DroneCAN GUI Tool.

Changes:

  • Introduce a py2app build configuration for creating a macOS .app.
  • Add a macOS build script to produce a .dmg in dist/.
  • Add a GitHub Actions workflow to run the macOS build and upload the .dmg artifact.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
setup_mac.py Adds py2app setup configuration for building a macOS app bundle.
macbuild.sh Automates venv setup, py2app build, and DMG packaging.
.github/workflows/macbuild.yml Adds a macOS CI job to run the build script and upload the DMG.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread macbuild.sh
Comment on lines +29 to +34
hdiutil create \
-volname "${APP_NAME}" \
-srcfolder "dist/${APP_NAME}.app" \
-ov \
-format UDZO \
"dist/DroneCAN_GUI_Tool.dmg"

Copilot AI Mar 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DMG packaging step references dist/${APP_NAME}.app, but py2app names the output bundle directory from the entry script basename (bin/dronecan_gui_tool), so the generated bundle path will be dist/dronecan_gui_tool.app by default. This will cause the hdiutil create step to fail in CI unless the source folder path is updated (or the py2app config is changed to emit the expected bundle name).

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/macbuild.yml Outdated
Comment thread .github/workflows/macbuild.yml Outdated
Comment thread setup_mac.py Outdated
@Huibean Huibean force-pushed the pr-add-macos-ci-build branch from 91c97cc to a488bd5 Compare March 29, 2026 03:58
@Huibean Huibean force-pushed the pr-add-macos-ci-build branch from a488bd5 to 9e8b2e4 Compare March 29, 2026 04:02
@Huibean

Huibean commented Mar 29, 2026

Copy link
Copy Markdown
Member Author

Hi @tridge , can you have a look on this, I have tested the CI build dmg, it is working

@Huibean Huibean assigned Huibean and unassigned Huibean Mar 29, 2026
@tridge tridge merged commit 0421807 into dronecan:master Mar 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants