Skip to content

widgets: Ensure Bus Monitor and Plotter both spawn QApplication with Fusion Style enabled#127

Merged
Huibean merged 1 commit into
masterfrom
pr/fix-Qt6-style-on-sub-applications
Apr 24, 2026
Merged

widgets: Ensure Bus Monitor and Plotter both spawn QApplication with Fusion Style enabled#127
Huibean merged 1 commit into
masterfrom
pr/fix-Qt6-style-on-sub-applications

Conversation

@joshanne

Copy link
Copy Markdown
Collaborator

Opening Bus Monitor and Plotter open new QApplications which default to the system style - so this will ensure all QApplications that are spawned use the Fusion style

…Fusion Style enabled

Opening Bus Monitor and Plotter open new QApplications which default to the system style - so this will ensure all QApplications that are spawned use the Fusion style

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures that subprocess-spawned Qt applications (Bus Monitor and Plotter) use the same “Fusion” style as the main GUI app, preventing platform-default style mismatches.

Changes:

  • Set Qt application style to “Fusion” in the Plotter subprocess entry point.
  • Set Qt application style to “Fusion” in the Bus Monitor subprocess entry point.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dronecan_gui_tool/widgets/plotter/init.py Applies Fusion style to the Plotter’s spawned QApplication for consistent UI styling.
dronecan_gui_tool/widgets/bus_monitor/init.py Applies Fusion style to the Bus Monitor’s spawned QApplication for consistent UI styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

logger.info('Plotter process started with PID %r', os.getpid())
app = QApplication(sys.argv) # Inheriting args from the parent process

# Set the style for Qt6 to be same across systems

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar: "to be same across systems" reads awkwardly. Consider changing to "to be the same across systems" (or similar) to improve clarity.

Suggested change
# Set the style for Qt6 to be same across systems
# Set the Qt6 style to be the same across systems

Copilot uses AI. Check for mistakes.
logger.info('Bus monitor process started with PID %r', os.getpid())
app = QApplication(sys.argv) # Inheriting args from the parent process

# Set the style for Qt6 to be same across systems

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar: "to be same across systems" reads awkwardly. Consider changing to "to be the same across systems" (or similar) to improve clarity.

Suggested change
# Set the style for Qt6 to be same across systems
# Set the Qt6 style to be the same across systems

Copilot uses AI. Check for mistakes.
@Huibean Huibean self-assigned this Apr 24, 2026

@Huibean Huibean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huibean Huibean merged commit 32b2892 into master Apr 24, 2026
9 checks passed
@joshanne joshanne deleted the pr/fix-Qt6-style-on-sub-applications branch April 25, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants