setup.py: Allow dronecan_gui_tool to be pip installed#128
Merged
tridge merged 1 commit intoMay 18, 2026
Merged
Conversation
…n setup.py install --user`
joshanne
changed the title
python setup.py install --userdronecan_gui_tool to be pip installed
tridge
approved these changes
May 18, 2026
joshanne
deleted the
pr/stop-desktop-file-install-on-pip-install-of-project
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a colleague try
pip installthis repo, and because of theinstall_freedesktopstep in setup.py, it tries to install to/usr/share/applications/.Honestly,
install_freedesktopas a module is old (2015) and the projects repository is no longer active on github.I would prefer to deprecate the install
.desktopfiles, but i'm unclear on how many users might be using the desktop launcher for the application.Building the wheel first then installing it allows the application to install, but the
.desktopfile is not valid in this case.This should close Issue #94 .