main: Fixes an incorrectly constructed environment PATH resulting in failure to subprocess system applications#132
Open
joshanne wants to merge 1 commit into
Conversation
…failure to launch applications While testing on Fedora 44, noticed that `_linux_parse_ip_link_show` was failing to run `ip link show`. After investigating, it was because `/usr/bin` was being dropped off the PATH because the windows hack made the PATH look like: `/home/user/.local/bin:/home/user/bin:/usr/local/bin:/usr/bin;/usr/bin`. That Windows PATH separator resulted in the `/usr/bin` folder not being usable on the PATH, and thus `ip link show` could not run.
Collaborator
Author
|
I've set up VMs for the latest of Fedora, Ubuntu and Debian. Ubuntu and Debian appear to be immune. On Ubuntu at least, there's an On Fedora, this error happens straight out of the box with a fresh install. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing on Fedora 44, noticed that
_linux_parse_ip_link_showwas failing to runip link show.After investigating, it was because
/usr/binwas being dropped off the PATH because the windows hack made the PATH look like:/home/user/.local/bin:/home/user/bin:/usr/local/bin:/usr/bin;/usr/bin.That Windows PATH separator resulted in the
/usr/binfolder not being usable on the PATH, and thusip link showcould not run.We fix this by using
os.pathsepto determine the appropriate path separator, and ensure the PATH is constructed correctly.