Fix #100: Validate ACL user IDs format#113
Open
a22405291LourencoMadeira wants to merge 12 commits intodrop-project-edu:masterfrom
Open
Fix #100: Validate ACL user IDs format#113a22405291LourencoMadeira wants to merge 12 commits intodrop-project-edu:masterfrom
a22405291LourencoMadeira wants to merge 12 commits intodrop-project-edu:masterfrom
Conversation
…nce some servers have problems with cdnjs.
…(protected by HTTP Basic Auth)
…(protected by HTTP Basic Auth)
…configuration This way it avoids bean conflicts related to having two userDetailsManager (the "normal" and the actuator)
…rface Adds functionality to compute and display disk usage for assignments, including file system (submissions and mavenized folders) and database usage (junit_report and build_report), sorted by total size.
…rface Adds functionality to compute and display disk usage for assignments, including file system (submissions and mavenized folders) and database usage (junit_report and build_report), sorted by total size.
…rface Adds functionality to compute and display disk usage for assignments, including file system (submissions and mavenized folders) and database usage (junit_report and build_report), sorted by total size.
…rface Adds functionality to compute and display disk usage for assignments, including file system (submissions and mavenized folders) and database usage (junit_report and build_report), sorted by total size.
palves-ulht
requested changes
Apr 21, 2026
Collaborator
palves-ulht
left a comment
palves-ulht
left a comment
There was a problem hiding this comment.
Nice work! Please check the ; as well - teacher1;teacher2 should also give an error.
Also, add tests for these two cases.
Collaborator
Also change the target branch, it should be drop-project:v1.0.0-beta.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
Fixes #100
When entering multiple teacher IDs in the "Other teachers (optional)" field without commas (e.g., using spaces like
teacher1 teacher2), the system accepts the input as a single invalid user ID. No validation error is shown.What is the new behavior?
The system now validates that each user ID does not contain spaces. If spaces are detected, a clear error message is shown:
Other information?
teacher1 teacher2(space instead of comma) and verified the error message appears correctly. Also tested with valid comma-separated values to ensure normal functionality still works.