fix(leaderboard): remove trailing slash before path variables in group link#115
Open
armorbreak001 wants to merge 1 commit intodrop-project-edu:masterfrom
Open
Conversation
…p link The Thymeleaf URL expression /submissions/(...) produced a double slash in the generated href (e.g. /submissions/?assignmentId=...), causing a 404 when clicking the group button on the leaderboard. Remove the extraneous '/' so the path variable syntax resolves to /submissions?assignmentId=... as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The leaderboard Show Group button generates a URL with a double slash due to an extraneous
/before Thymeleaf path variable syntax. This causes a 404 error when teachers click the group button.Root cause: In
leaderboard.htmlline 54, the expression@{/submissions/(...)places a/immediately before(, which resolves as two separate path segments instead of path variables — producing the malformed href.Fix: Remove the trailing slash so the expression becomes
@{/submissions(...)}, which correctly resolves to the intended URL.Fixes #110
Changes
leaderboard.html