fix: add validation to reject invalid characters in assignment ID#116
Open
Gasg10 wants to merge 2 commits intodrop-project-edu:v1.0.0-beta.5from
Open
fix: add validation to reject invalid characters in assignment ID#116Gasg10 wants to merge 2 commits intodrop-project-edu:v1.0.0-beta.5from
Gasg10 wants to merge 2 commits intodrop-project-edu:v1.0.0-beta.5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98
Problem
When creating an assignment with a backslash (
\) in the ID field, the application returned an HTTP 404 error instead of a proper validation message.Root Cause
The
assignmentIdfield inAssignmentForm.kthad no pattern validation, so any character was accepted. When a backslash was submitted, the URL routing failed with 404.Fix
Added a
@Patternannotation to theassignmentIdfield inAssignmentForm.ktto only allow letters, numbers, hyphens and underscores:Testing
test\assignmentin the ID field and fill the other required fields