fix: preserve tag filter after toggling assignment status#117
Open
Gasg10 wants to merge 3 commits intodrop-project-edu:v1.0.0-beta.5from
Open
fix: preserve tag filter after toggling assignment status#117Gasg10 wants to merge 3 commits intodrop-project-edu:v1.0.0-beta.5from
Gasg10 wants to merge 3 commits intodrop-project-edu:v1.0.0-beta.5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Problem
When a tag filter was applied in the Current Assignments page and the teacher toggled the Active? checkbox, the tag filter was lost after the redirect. The page returned to the default state showing all assignments.
Root Cause
The
toggleAssignmentStatuscontroller did not receive or preserve the active tag filter. After toggling, it always redirected to/assignment/mywithout any query parameters, discarding the selected tags.Fix
Three changes were made:
1.
AssignmentController.kt— Addedtagsas a@RequestParamtotoggleAssignmentStatusand used it in the redirect:2.
AssignmentController.kt— AddedcurrentTagsto the model inlistMyFilteredAssignments:3.
teacher-assignments-list.html— Added a hidden input to pass the current tags when the toggle form is submitted:Testing
kotlin) — only filtered assignments are shown