fix: issue #93 and fix: forcing checkstyle language to English#119
Open
a22407332FilipeMonteiro wants to merge 1 commit intodrop-project-edu:v1.0.0-beta.5from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Fix missing indicator for Project Structure errors + Force English for test executio
Closes#93
Description
This PR addresses two issues:
Root Cause
Project Structure Indicator
In
SubmissionService.kt, thereportElementswere being fetched inside thebuildReport?.let { }block. This meant that submissions without abuildReport(such as those with Project Structure errors) never had theirreportElementspopulated, resulting in an empty Indicators column in the UI.Locale Issue
While running the test suite, most of the tests were failling, but one message appeared in Portuguese, which was unexpected. After investigation, it became clear that having the OS language set to Portuguese was preventing the tests from executing correctly. Switching the system language to English allowed all tests to pass, confirming the root cause.
Solution
Project Structure Indicator
In
SubmissionService.kt, moved thereportElementsfetch outside of thebuildReport?.let { }block, so that it is always executed regardless of whether abuildReportexists.Before:
After:
Locale Fix
request.mavenOpts = "-Duser.language=en -Duser.country=US"inMavenInvoker.ktto force Maven to always run with English locale, regardless of the OS language.Result
Testing
Project Structure Indicator
Locale Fix