fix: throw StateError on circular dependency detection#6
Merged
Conversation
Modify `InjectorGraphResolver` to accumulate detected circular dependencies and throw a descriptive `StateError` to immediately fail the build. Previously, cycles were only logged to a detached `Logger` instance, which remained hidden from stdout and allowed the builder to silently succeed while emitting invalid recursive code that stack-overflowed at runtime. - Throws `StateError` on dependency cycles during graph resolution. - Updates unit tests to assert cycle failures. - Bumps `inject_compile_generator` version to `0.9.2` and updates the changelog. Closes #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
InjectorGraphResolverto accumulate detected circular dependencies and throw a descriptiveStateErrorto immediately fail the build. Previously, cycles were only logged to a detachedLoggerinstance, which remained hidden from stdout and allowed the builder to silently succeed while emitting invalid recursive code that stack-overflowed at runtime.StateErroron dependency cycles during graph resolution.inject_compile_generatorversion to0.9.2and updates the changelog.Closes #5