fix: validate missing dependencies and refactor SummaryReader to nullable#8
Merged
Conversation
…able Implement compile-time validation for missing dependency providers to fail the build runner step early with a descriptive error message. Also refactors the `SummaryReader` API to return a nullable `LibrarySummary?` instead of throwing a `FileSystemException` when a summary does not exist, allowing `resolveKey` to use a clean null-check instead of control-flow exception try/catch blocks. - Tracks all requested dependencies and throws `StateError` if any lack a provider. - Refactors `SummaryReader` and mock/fake test implementations to return nullable summaries. - Adds a unit test for missing dependency validation. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement compile-time validation for missing dependency providers to fail the build runner step early with a descriptive error message.
Also refactors the
SummaryReaderAPI to return a nullableLibrarySummary?instead of throwing aFileSystemExceptionwhen a summary does not exist, allowingresolveKeyto use a clean null-check instead of control-flow exception try/catch blocks.StateErrorif any lack a provider.SummaryReaderand mock/fake test implementations to return nullable summaries.Closes #7