Fix error comparison and reflection robustness in share-link commands#299
Merged
Conversation
Replace fragile interface pointer comparisons with reflection-based samePointer helper, migrate error assertions to errors.Is for correct wrapped-error handling, and extract ErrorSummary via direct field reflection to avoid CanInterface pitfalls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parsed == &appErr) with reflection-basedsamePointerhelper that correctly compares underlying pointer addresses regardless of interface wrapper typeerr != wantErrtest assertions toerrors.Is(err, wantErr)for correct wrapped-error handlingErrorSummaryvia direct field reflection instead ofCanInterface()+ type assertion to avoid pitfalls with unexported fieldsTest plan
go test ./cmd/...passesgolangci-lint runclean