Add --content, --limit, and --order-by flags to search#300
Merged
Conversation
Expose Dropbox SearchV2 options: content search (vs filename-only default), server-side result limit with client-side pagination cap, and server-side ordering by relevance or modified time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--content/-cflag to search file contents (default is filename-only search)--limitflag to cap total results with both server-sideMaxResultsand client-side pagination stop--order-byflag for server-side ordering (relevanceormodified)Test plan
go test ./cmd/...passesgolangci-lint runcleandbxcli search --content --limit 5 "report"returns at most 5 content-matched resultsdbxcli search --order-by modified "report"returns results ordered by last modifieddbxcli search --order-by invalid "report"returns validation error