fix: MCD-601: Remove unnecessary content_lock release before entity deletion #35
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cleanUpContent()before entity deletionhook_entity_predelete()blocked deletion of locked entities (viaexit(0)), so releasing locks first was necessaryhook_entity_access()for thedeleteoperation, which$entity_storage->delete()does not invoke — so the lock release is no longer neededhook_entity_delete()after deletionSupersedes #32
Test plan