Refactoring election. See issue-60.#61
Open
dianaalinairimie wants to merge 2 commits intodrupalro:sprintfrom
Open
Refactoring election. See issue-60.#61dianaalinairimie wants to merge 2 commits intodrupalro:sprintfrom
dianaalinairimie wants to merge 2 commits intodrupalro:sprintfrom
Conversation
dianaalinairimie
force-pushed
the
issue-60
branch
2 times, most recently
from
962a2c7 to
cecd5f7
Compare
benelori
reviewed
Sep 13, 2017
| services: | ||
| da_poll.service: | ||
| class: Drupal\da_poll\Controller\PollController | ||
| arguments: [] |
Contributor
There was a problem hiding this comment.
If there are no arguments for the service, then there's no need to add it.
benelori
reviewed
Sep 13, 2017
| * An array suitable for drupal_render(). | ||
| */ | ||
| public function revisionShow($da_poll_revision) { | ||
| $da_poll = $this->entityManager() |
Contributor
There was a problem hiding this comment.
The entity manager service is deprecated. Please inject the entity type manager and use that.
added 2 commits
September 13, 2017 11:49
…xist anymore. See issue-60.
dianaalinairimie
force-pushed
the
issue-60
branch
from
cecd5f7 to
06e01a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.