Open
Conversation
Remove self attributes: pmra, pmdec, and rv. Package internally to the SkyCoord object.
for more information, see https://pre-commit.ci
typo fix from numpy.zeroes to numpy.zero
for more information, see https://pre-commit.ci
Initial updates with maturation still needed for starprop function before final fix.
for more information, see https://pre-commit.ci
Initial attempt for starprop update based on SkyCoord changes.
for more information, see https://pre-commit.ci
Added a default epoch to ensure deterministic propagation and avoid hidden Astropy defaults.
for more information, see https://pre-commit.ci
Import time from astropy for proper SkyCoord function and update docstrings for relocated kinematic parameters.
for more information, see https://pre-commit.ci
apply_space_motion instead of manually computing vectors
for more information, see https://pre-commit.ci
appended [sInds] to coord_old within starprop.
for more information, see https://pre-commit.ci
sInds contains one index so it is scalar when it needs to be an array.
for more information, see https://pre-commit.ci
Attempt to force array semantics. Problem appears to originate from astropy and/or SkyCoord metadata being scalar for the case of 1.
for more information, see https://pre-commit.ci
importing astropy Skycoord
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Call SkyCoord directly.
for more information, see https://pre-commit.ci
updates for transforming coordinate system to heliocentric true eclipltic
for more information, see https://pre-commit.ci
arange's final value would sometimes be less than endTime, and this would sometimes cause interpolation to return nan.
for more information, see https://pre-commit.ci
Note that an if statement was not included (for adding dt to endTime) to eliminate any possibility of a floating point error, given that the values are all floats.
…nto apply_space_motion_jmr
…nto apply_space_motion_jmr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed starprop method to use astropy's apply_space_motion. Required packaging proper motion and radial velocity values into StarCatalog/TargetList coords and deprecating the proper motion and radial velocity attributes. Also fixed a probabilistic error that occurred during some e2e tests.
Type of change
Reference any relevant issues (don't forget the #)
#313
Checklist before requesting a review
e2eTestsand added new test scripts, as needed