Open
Conversation
1. core_platescale rescaling: add 0.0 to prevent being the same object as syst["core_platescale"]. This is in OpticalSystem Prototype 2. change round to np.round in SurveySimulation Prototype
Update PostProcessing.py
Currently have the following: - signal is Cp*t - error is square root term in SNR - outputting wavelength bins, signal, and error as the 'spectrum' in the DRM - star count rate C_star is also outputted to DRM - stellar flux is wavelength dependent - most count rates are wavelength dependent; exceptions are Cez and Cz which are an array of constant value and noise count rates which are single values - the function Cp_Cstar_wl is the master function that makes the wavlength dependent counts. There is a prototype version and a Nemati version
-Added file of QE vs lambda -Cp_Cb_Csp_Cstar_wl function now uses the wavelength dependent QE
Incorporate wavelength dependency for count rates in optical system, specifically in the Cp_Cb_Csp_Cstar_wl function
Bug fixes, clean up comments, add new comments for calculating and outputting spectra in simulation
Implement OS class for allowing parameterized coronagraph based on the equations from Tokadjian et al in the HWO25 Conference Proceedings
Minor edits to pass unit tests and incorporate necessary docstrings
for more information, see https://pre-commit.ci
Removed unused variables, updated docstrings
… into spectrum_for_chars
for more information, see https://pre-commit.ci
… into spectrum_for_chars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added capability to:
1 - use spectra from precomputed tables using the 'use_spectrum' keyword. Allows for wavelength dependent calculations.
2 - output spectra of characterized planets (wavelength vs planet counts) with appropriate error bars using 'calc_spectra' keyword
3 - use parameterized equations for coronagraph performance curves with Nemati_ct_iwa_2xbg.py
Type of change
Reference any relevant issues (don't forget the #)
Checklist before requesting a review
e2eTestsand added new test scripts, as needed