Prefix the path to write the output to with the path in env variable TEST_UNDECLARED_OUTPUTS_DIR#6
Merged
dsharlet merged 1 commit intodsharlet:mainfrom Aug 29, 2025
Conversation
jensmassberg
force-pushed
the
use-test-undeclared-outputs-path
branch
from
78365d0 to
8f862e1
Compare
dsharlet
approved these changes
Aug 29, 2025
dsharlet
reviewed
Aug 29, 2025
Owner
dsharlet
left a comment
dsharlet
left a comment
There was a problem hiding this comment.
Thanks for the fixes, just one small nit remaining from looking at the GitHub actions log.
…TEST_UNDECLARED_OUTPUTS_DIR. With this change tests can be run under bazel and the trace file will be added bazel testlogs. The directory will be ignored if env var IN_PTHREAD_TRACE_TEST is set.
jensmassberg
force-pushed
the
use-test-undeclared-outputs-path
branch
from
8f862e1 to
3e17bd1
Compare
dsharlet
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change tests can be run under bazel and the trace file will be added bazel testlogs. The directory will be ignored if env var IN_PTHREAD_TRACE_TEST is set.