Skip to content

no rows cache for streaming spreadsheet #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
musketyr merged 1 commit into from
Jun 24, 2025
Merged

no rows cache for streaming spreadsheet #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...heet-builder-api/src/main/java/builders/dsl/spreadsheet/impl/AbstractSheetDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ protected AbstractWorkbookDefinition getWorkbook() {
return workbook;
}

private RowDefinition findOrCreateRow(int zeroBasedRowNumber) {
protected RowDefinition findOrCreateRow(int zeroBasedRowNumber) {
AbstractRowDefinition row = rows.get(zeroBasedRowNumber + 1);

if (row != null) {
Expand Down
11 changes: 11 additions & 0 deletions ...et-builder-poi/src/main/java/builders/dsl/spreadsheet/builder/poi/PoiSheetDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package builders.dsl.spreadsheet.builder.poi;

import builders.dsl.spreadsheet.builder.api.PageDefinition;
import builders.dsl.spreadsheet.builder.api.RowDefinition;
import builders.dsl.spreadsheet.builder.api.SheetDefinition;
import builders.dsl.spreadsheet.impl.AbstractSheetDefinition;
import org.apache.poi.ss.usermodel.Row;
Expand All @@ -34,10 +35,20 @@ class PoiSheetDefinition extends AbstractSheetDefinition implements SheetDefinit
public static final int MAX_COLUMN_WIDTH = 255 * 256;

private final Sheet sheet;
private final boolean streaming;

PoiSheetDefinition(PoiWorkbookDefinition workbook, Sheet sheet) {
super(workbook);
this.sheet = sheet;
this.streaming = sheet instanceof SXSSFSheet;
}

@Override
protected RowDefinition findOrCreateRow(int zeroBasedRowNumber) {
if (streaming) {
return createRow(zeroBasedRowNumber);
}
return super.findOrCreateRow(zeroBasedRowNumber);
}

@Override protected PoiRowDefinition createRow(int zeroBasedRowNumber) {
Expand Down
Loading