Skip to content

Fix: Replace bare print with warning and remove deprecated Python 2 code #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mithlohar144 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: Replace bare print with warning and remove deprecated Python 2 code #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0a5082
Fix: Replace bare print with warning and remove deprecated Python 2 code
mithlohar144 Mar 28, 2026
52d64f9
Fix trailing whitespace in test_GAM_methods for pre-commit
mithlohar144 Mar 28, 2026
b3632f7
Revert convergence warning to print for CI stability
mithlohar144 Mar 28, 2026
e501e7d
Use Agg backend in gen_imgs to avoid Tk/Tcl CI failures
mithlohar144 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gen_imgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
"""Generate some plots for the pyGAM repo."""

import matplotlib

matplotlib.use("Agg")
import matplotlib.pyplot as plt
import numpy as np
from matplotlib.font_manager import FontProperties
Expand Down Expand Up @@ -323,7 +326,6 @@ def chicago_tensor():


def expectiles():

"""Generate expectiles visualization."""
X, y = mcycle(return_X_y=True)

Expand Down
6 changes: 2 additions & 4 deletions pygam/tests/test_GAM_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,8 @@ def test_summary_returns_12_lines(mcycle_gam):
known smoothing parameters, but when smoothing parameters have been estimated, the p-values
are typically lower than they should be, meaning that the tests reject the null too readily.
""" # noqa: E501
if sys.version_info.major == 2:
from StringIO import StringIO
if sys.version_info.major == 3:
from io import StringIO # noqa: F811
from io import StringIO

stdout = sys.stdout # keep a handle on the real standard output
sys.stdout = StringIO() # Choose a file-like object to write to
mcycle_gam.summary()
Expand Down
Loading