Fix nested parameter routing in set_params for term-specific parameters#585
Open
ishan372or wants to merge 2 commits into
Open
Fix nested parameter routing in set_params for term-specific parameters#585ishan372or wants to merge 2 commits into
ishan372or wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for sklearn-style nested parameter routing in set_params.
Previously, nested parameters such as:
gam.set_params(terms__0__n_splines=30)were treated as literal attribute names and silently ignored. As a result, term-specific hyperparameter tuning through tools such as
GridSearchCVwould not actually modify the underlying terms.Referencing: #580
Changes:
Added support for resolving nested parameter paths containing
__.Added a regression test covering term-specific parameter updates.