Add --exit-with-parent watchdog#2
Merged
Merged
Conversation
Adds an opt-in CLI flag that makes the server exit when its parent process dies — even on a crash/SIGKILL where the parent can't run its own cleanup. A host app that launches LiveAudioServer as a helper can pass --exit-with-parent to guarantee the server is reaped rather than orphaned holding its HTTP port. Implementation: ServerConfig.exitWithParent (parsed in CLIParse) gates a DispatchSource timer in the CLI that polls getppid(); when the process is reparented (to launchd, pid 1) it runs the existing graceful shutdown. Library behavior is unchanged when the flag is absent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in CLI flag that makes the server exit when its parent process dies — even on a crash/SIGKILL where the parent can't run its own cleanup. A host app that launches LiveAudioServer as a helper can pass --exit-with-parent to guarantee the server is reaped rather than orphaned holding its HTTP port.
Implementation: ServerConfig.exitWithParent (parsed in CLIParse) gates a DispatchSource timer in the CLI that polls getppid(); when the process is reparented (to launchd, pid 1) it runs the existing graceful shutdown. Library behavior is unchanged when the flag is absent.