Skip to content

Update KakyomuParser to handle new TOC Updates #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dteviot merged 1 commit into from
Apr 16, 2026
+1 −1
Merged

Update KakyomuParser to handle new TOC Updates #2629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/js/parsers/KakuyomuParser.js
View file
Open in desktop
Copy link
Copy Markdown

@Anos9029 Anos9029 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixed? I still get an error when I try

Copy link
Copy Markdown
Contributor Author

@lemonatez lemonatez Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR isn't get approved yet. my update version is working now

image

Copy link
Copy Markdown

@Anos9029 Anos9029 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR isn't get approved yet. my update version is working now

image

how do you update your version of the code? do you run it without an extension?

Copy link
Copy Markdown
Contributor Author

@lemonatez lemonatez Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build the extention using my fork

Copy link
Copy Markdown

@Jokakun Jokakun Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully downloaded all chapters from a kakuyomu link, using your version. However the download prompt is not appearing. When i click error in extension page, it shows....

Uncaught (in promise) ReferenceError: DOMPurify is not defined

any idea?

Copy link
Copy Markdown

@Anos9029 Anos9029 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the process is 100% complete, there's usually an option to save the EPUB file. This one doesn't appear, and instead, there's an error in the DOM.

Copy link
Copy Markdown
Contributor Author

@lemonatez lemonatez Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird...are you sure you build it correctly? clone my project -> npm install -> npm run init
i try reinstall since start it works well.

Copy link
Copy Markdown

@Anos9029 Anos9029 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks, I followed your project and it worked, for the official one, even though the owner said it had been merged, it still had the same error with the table of contents.

Copy link
Copy Markdown

@Jokakun Jokakun Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange, I downloaded the latest developer extension, and was able to download 3 kakuyomu novels without issue

Copy link
Copy Markdown

@Anos9029 Anos9029 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, maybe I'll try again later.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class KakuyomuParser extends Parser {
let json = JSON.parse(script).props.pageProps.__APOLLO_STATE__;
let work = json["Work:" + this.extractWorkId(dom)];
let chapters = [];
for (let tocc of work.tableOfContents) {
for (let tocc of work.tableOfContentsV2) {
this.buildSubToc(chapters, json[tocc.__ref], json, dom.baseURI);
}
return chapters;
Expand Down
Loading