Fix Ranobes chapter title fallback#2649
Merged
dteviot merged 1 commit intodteviot:ExperimentalTabModefrom May 5, 2026
Merged
Conversation
Handle Ranobes reader pages that put chapter headings inside the article content while keeping the existing h1.title behavior for normal Ranobes pages.
Owner
|
Thank you. You should have added yourself to the credits, but I'll take care of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the Ranobes reader pages put the chapter title inside
div#arrticleinstead ofh1.title. This fix checks the existingh1.titleselector first, then falls back to article headings, so normal Ranobes pages keep their current behavior. Without this, the download would never happen, due to a crash (from the failure parsing).