Add support for safe keyword in foreign functions and statics#1963
Open
Wasabi375 wants to merge 3 commits intodtolnay:masterfrom
Open
Add support for safe keyword in foreign functions and statics#1963Wasabi375 wants to merge 3 commits intodtolnay:masterfrom
safe keyword in foreign functions and statics#1963Wasabi375 wants to merge 3 commits intodtolnay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1756
This is an alternate solution to implement this and would also close #1960. As I explained in the issue this is probably the best way to do this, but I might be wrong again. I thought the same when I created #1960 but here I am again creating a second PR for the same issue 🤷♂️ I guess we could just discuss this in the issue, but writing this out helped me think through the problem.
Open questions: