Distributed sessions (rebased)#2
Open
jerenkrantz wants to merge 2 commits into
Open
Conversation
- Eliminate read-modify-write race in updateSessionStateInBackend by reconstructing SessionData directly instead of Get+mutate+Update - Extract userID earlier so OnStateChange callbacks can capture it - Add 10s timeout to context.Background() used for backend session deletion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionBackendinterface for distributed session management across multiple server replicasMemorySessionBackend) for development/testingStreamableHTTPHandlerfor session persistence and cross-pod message routingChanges from original PR
randText()→rand.Text()to match upstream API changeupdateSessionStateInBackendwith directUpdateusing reconstructedSessionData, eliminating concurrent state clobber between pods/goroutinescontext.Background()used for backend session deletion inonClosecallbackuserIDextraction earlier soOnStateChangecallbacks can capture it without a secondTokenInfoFromContextcallTest plan
go build ./mcp/...passesgo test ./mcp/...passesgo test -race ./mcp/...passesmcp/distributed_test.gomcp/session_backend_integration.go🤖 Generated with Claude Code