Process the token claims at the end of msal scheme. call #54
Open
tjadevries wants to merge 5 commits intodudil:masterfrom
Open
Process the token claims at the end of msal scheme. call #54tjadevries wants to merge 5 commits intodudil:masterfrom
tjadevries wants to merge 5 commits intodudil:masterfrom
Conversation
Add claims processing to MSALScheme
export default_claims_processing
Add claims processing to MSALAuthorization, so that it can be passed to MSALScheme
There was a problem hiding this comment.
Pull Request Overview
This PR implements feature request #53 by adding support for custom token claims processing in the MSAL authentication scheme. The implementation allows for processing of token claims at the end of authentication with an optional callback function.
- Added a
claims_processingparameter to allow custom handling of token claims - Introduced a
default_claims_processingfunction that extracts user info from token claims - Updated the authentication flow to call the claims processing function after token validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fastapi_msal/security/msal_scheme.py | Added claims processing functionality with default implementation and callback support |
| fastapi_msal/security/init.py | Exported the new default_claims_processing function |
| fastapi_msal/auth.py | Updated MSALAuth class to accept and pass through claims_processing parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements feature request as described in issue #53