feat(sweep): profile args, qwen KV rule, 4k active default, artifact rebuild#17
Merged
Conversation
…artifact CreateOrAppend treats an empty existing file as a fresh artifact and rejects directories.
… destinations; boolean flag omission Codex review round 1: artifact rebuild reconstructs from the run's normalized spec (--spec is provenance-only); a failed merge into a zero-byte destination removes it like a fresh file; omitting a boolean engine flag no longer swallows the following flag.
Member
Author
|
Final report: integrates the four feat/localperf-viewer-mode commits onto main, reconciled with the report-integrity cutover (rebuild rehomed as 'artifact rebuild'; qwen KV rule extended to the --kv-cache-memory-bytes intent flag; 4k active default merged with the provenance flags). Codex round 1: 2 P2 + 1 P3 (rebuild used the original spec for reconstruction; failed merges left initialized empty destinations; boolean flag omission swallowed the next flag) — all fixed in f5e76a2 with regression tests; P2-or-lesser round ends the loop. Gates: go test/vet, gofmt, simpledoc, slophammer check/dry, check-crap, golangci-lint all clean; artifact rebuild smoke-tested end to end; CI green. Merging per explicit authorization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The feat/localperf-viewer-mode branch carried four commits that never landed: generator profile-args flags, the qwen fixed-KV-cache rule, the 4k active default ladder, and rebuilding an artifact from a run directory.
This change integrates all of them onto main, resolved against the report-integrity cutover.
The rebuild feature moves from the deleted
bench report --artifactto a newartifact rebuildsubcommand.What Changed
All four commits are cherry-picked and reconciled with the provenance/cutover work.
artifact rebuild --run-dir … [--into …] [--spec …]reconstructs a SQLite artifact from a run directory's events/results/summary.json (rehomed frombench report --artifact, which no longer exists).artifact.CreateOrAppendnow rejects directories and initializes empty existing files.sweep plangains--profile-arg,--profile-engine-arg, and--omit-profile-engine-flag(repeatable), composing with the provenance intent flags.--kv-cache-memory-bytesfrom inherited engine args, and the same rule now covers the--kv-cache-memory-bytesintent flag.4k(4k,8k,16k,32k,64k); docs, AGENTS.md, and usage updated; sweepplan golden regenerated (grid changes are hash-visible through the generator stamp).Testing
All gates pass and the rebuild path was smoke-tested end to end.
go test ./...,go vet,gofmt,simpledoc,slophammer check/dry,check-crap.sh,golangci-lint— cleanartifact rebuild --run-dir …,artifact check— okRisks
Conflict resolution touched sweep plan flag wiring; the golden test pins the merged output.
The rebuilt artifact reflects the run directory's summary.json; a run dir without one fails cleanly.