fix(viewer): stop engine-mismatch warning stretching full-height on load#20
Merged
Conversation
…on load The .app grid used 'grid-template-rows: auto 1fr', but the engine-mismatch warning is a third grid child — it landed in the 1fr row and, with grid's default align-items: stretch, the banner filled the whole viewport height during initial load before the tab content settled. Switch .app to a flex column and let .tabs-root grow (flex: 1) so the warning stays auto-height and the content area fills the space instead. Rebuilt web/dist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On first load the engine-mismatch warning banner briefly filled the whole screen before the tables settled.
Cause:
.appusedgrid-template-rows: auto 1fr, but the warning is a third grid child, so it landed in the1frrow and grid's defaultalign-items: stretchblew the yellow banner up to full viewport height until the tab content loaded.What Changed
CSS-only, in
internal/viewer/web/src/styles.css(+ rebuiltweb/dist)..app:display: grid; grid-template-rows: auto 1fr→display: flex; flex-direction: column, so children keep their natural height and nothing stretches..tabs-root:flex: 1so the content area still grows to fill the viewport (preserving the original1frintent) instead of the warning doing so.Testing
Rebuilt
web/dist,go build ./cmd/localperfpasses, viewer relaunched and verified: engine warning stays a compact banner, tabs/content fill correctly, prior width-cap and heat-fill styling intact.Risks
Low — CSS-only, no logic change.