feat: use pi-factory for pi launch wiring#13
Merged
Conversation
Member
Author
|
Autoimplementation update:
|
Member
Author
|
Final report for the latest implementation pass:
Validation run locally:
CI:
Note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened on behalf of Onur Solmaz (
osolmaz). This PR is ready for review.Depends on dutifuldev/pi-factory#1.
Summary
localpi had its own Pi config generation and Pi process launch wiring.
This change moves that generic Pi-app work to Pi Factory and keeps localpi focused on local model/runtime discovery.
It removes duplicated config/spawn code while preserving localpi's behavior and tests.
What Changed
localpi now builds a Pi Factory app definition after it resolves the local runtime and selected model.
Pi Factory writes the Pi runtime config and creates/executes the launch plan.
src/pi/app.tsadapter from localpi runtime state to a Pi Factory app definition.models.json/settings.jsonwriter withwritePiRuntimeConfig.createPiLaunchPlanandexecPiLaunchPlan.llama-server, demo mode, thinking settings, and extensions.Testing
I tested this without loading any new model into memory and without starting a real model-backed Pi session.
The existing tests use fake local runtimes and fake commands.
npm run formatnpm run lintnpm run typechecknpm testnpm run buildnpm run checkRisks
The main risk is dependency ordering.
localpi depends on the Pi Factory branch from PR #1 until Pi Factory is merged and released.