feat: manage pool membership in Space#3
Merged
Conversation
Member
Author
|
Final report:
Merging autonomously as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pool owners had to edit Space environment variables to add friends.
This change moves day-to-day membership management into the Space itself.
Admins can now add members, remove members, and promote or demote admins from the web UI, while bootstrap Space variables remain as recovery access.
What Changed
Membership is now durable data in the private dataset instead of only runtime environment config.
The Space loads
config/pool.json, falls back to bootstrap variables when needed, and commits membership edits through the existing dataset token.PoolMembershipservice./connect, ingest, explorer APIs, and/api/meto use the shared membership source.POOL_ADMINSand docs to describe the new flow.Testing
I tested the backend membership behavior, the frontend admin flow, and the full repo gate locally.
The production Space deployment still needs to rebuild from this branch after merge before the Admin tab is live there.
npm run test --workspace spacepassed.npm run test --workspace explorerpassed.npm run typecheck --workspace setuppassed.npm run checkpassed.npm run buildpassed.Risks
The main risk is membership migration from the existing
ALLOWED_USERSvariable.The code keeps a bootstrap fallback: when
config/pool.jsondoes not exist, the current allowed users become initial members andPOOL_ADMINSor the first allowed user becomes admin.config/pool.json, that file becomes the source of truth for ordinary members.POOL_ADMINSis changed in Space variables.