feat: add update-only Space deploy#4
Merged
Merged
Conversation
d5219b2 to
d405cde
Compare
Member
Author
|
Final report:
Merging autonomously as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened on behalf of Onur Solmaz (
osolmaz). Work is in progress.Summary
Redeploying an existing pool should not ask for all setup answers again.
This adds an update-only command that reads the existing Space settings and uploads the latest Space code.
It preserves the dataset token, signing secrets, session secrets, and import state.
What Changed
The first-time setup flow stays available for creating a pool.
Existing pools now have a shorter path for normal code deploys.
npm run update, which runs the setup CLI inupdatemode.update [owner/xtap-pool].Testing
Local validation passes.
The live Hugging Face deploy itself was not run from this PR.
npm run test --workspace setupnpm run typecheck --workspace setupnpm run checknpm run buildgit diff --checknpm run update -- not-a-reporejects before any network call.Risks
The update path intentionally fails if the existing Space or dataset has the wrong visibility.
That is safer than silently creating or updating the wrong pool.
DATASET_REPO, update mode falls back to<space-owner>/xtap-pool-data.ALLOWED_USERSorPOOL_ADMINS, update mode falls back to the active HF user for bootstrap access.