Add Vehicle Registration Number fetching#37
Open
krejcar25 wants to merge 2 commits intodvejsada:masterfrom
Open
Add Vehicle Registration Number fetching#37krejcar25 wants to merge 2 commits intodvejsada:masterfrom
krejcar25 wants to merge 2 commits intodvejsada:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I implemented another API request, that pulls information about each trip. It pulls uses this information to offer the vehicle registration number as an attribute. It might be useful for public transport enthusiasts.
This PR does increase the amount of requests towards Golemio. It might not be a bad idea to include a config option during setup to enable / disable this feature, simply by adding a condition to dep_board_api.py#L52:
PID_integration/custom_components/pid_departures/dep_board_api.py
Line 52 in 01d9a18