Open
Conversation
|
@dvtng Do you plan on picking up on community additions to make your lib better or is this repo abandoned? 😅 If so, would be great to state so in the Readme :) Thanks! |
Collaborator
|
Sorry, I had not given this a proper look. I'm not sure about merging this, because it is a pretty different way of thinking about the component. Is this feature you added compatible with all of the existing features of react-loading-skeleton? For example, the If you want to use |
Author
|
@srmagura Hi, Maybe we can test it, Radix does it, you can pass children it does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.