Skip to content

Fix: resolve memory leaks and remove debug info leakage #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rm335 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix: resolve memory leaks and remove debug info leakage #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LauncherApplication/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
}

func applicationWillTerminate(_ aNotification: Notification) {
// Insert code here to tear down your application
DistributedNotificationCenter.default().removeObserver(self)
}


Expand Down
4 changes: 4 additions & 0 deletions hidden/Features/Preferences/PreferencesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ class PreferencesViewController: NSViewController {
}
}

deinit {
NotificationCenter.default.removeObserver(self)
}

//MARK: - VC Life cycle
override func viewDidLoad() {
super.viewDidLoad()
Expand Down
10 changes: 5 additions & 5 deletions hidden/Features/StatusBar/StatusBarController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ class StatusBarController {
setupUI()
setupAlwayHideStatusBar()
NotificationCenter.default.addObserver(self, selector: #selector(handleScreenParametersChanged), name: NSApplication.didChangeScreenParametersNotification, object: nil)
DispatchQueue.main.asyncAfter(deadline: .now() + 1, execute: {
self.collapseMenuBar()
})
DispatchQueue.main.asyncAfter(deadline: .now() + 1) { [weak self] in
self?.collapseMenuBar()
}

if Preferences.areSeparatorsHidden {hideSeparators()}
autoCollapseIfNeeded()
Expand Down Expand Up @@ -157,8 +157,8 @@ class StatusBarController {
if isToggle {return}
isToggle = true
self.isCollapsed ? self.expandMenubar() : self.collapseMenuBar()
DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) {
self.isToggle = false
DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) { [weak self] in
self?.isToggle = false
}
}

Expand Down
1 change: 0 additions & 1 deletion hidden/Models/GlobalKeybindingPreferences.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ struct GlobalKeybindPreferences: Codable, CustomStringConvertible {
let keyCode : UInt32

var description: String {
print(keyCode)
var stringBuilder = ""
if self.function {
stringBuilder += "Fn"
Expand Down