Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a redesign of the heading component to align with the new design kit specifications and token architecture. Key changes include:
- Removal of the explicit "bold" weight from DxcHeading instances across multiple pages.
- Updated heading level handling to support level 6 where applicable.
- Adjustments to code examples and documentation to reflect the new heading API.
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/website/screens/principles/iconography/IconographyPage.tsx | Removed the explicit bold weight from the Iconography heading. |
| apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx | Removed the bold weight from the Data visualization heading. |
| apps/website/screens/principles/color/ColorPage.tsx | Removed the bold weight from the Color heading. |
| apps/website/screens/overview/releases/ReleasesPage.tsx | Removed the bold weight from the Releases heading. |
| apps/website/screens/overview/introduction/IntroductionPage.tsx | Removed the bold weight from the Introduction heading. |
| apps/website/screens/overview/installation/InstallationPage.tsx | Removed the bold weight from the Installation heading. |
| apps/website/screens/overview/component-lifecycle/ComponentLifecyclePage.tsx | Removed the bold weight from the Component lifecycle heading. |
| apps/website/screens/components/heading/code/examples/basicUsage.ts | Updated code example to illustrate multiple heading levels. |
| apps/website/screens/components/heading/code/HeadingCodePage.tsx | Updated the prop documentation for "level", "as", "margin", and "weight" to include support for level 6 and revised allowed values. |
| apps/website/screens/components/heading/HeadingPageLayout.tsx | Revised heading description to be more concise and consistent with the new design. |
| apps/website/screens/common/HeadingLink.tsx | Removed the explicit bold weight from the heading rendered within the link component. |
| apps/website/screens/common/ComponentHeading.tsx | Removed the explicit bold weight from the component heading in favor of the new default styling. |
| apps/website/pages/components/heading/index.tsx | Updated to use the new HeadingOverviewPage instead of the previous code/spec pages. |
Comments suppressed due to low confidence (1)
apps/website/screens/common/ComponentHeading.tsx:7
- The explicit 'bold' weight was removed from the ComponentHeading. Verify that the default styling now applied meets the intended design specifications for visual hierarchy.
<DxcHeading level={1} text={name} />
Mil4n0r
requested changes
Apr 23, 2025
apps/website/screens/components/heading/overview/HeadingOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/heading/overview/HeadingOverviewPage.tsx
Outdated
Show resolved
Hide resolved
Mil4n0r
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of the heading component following the new design kit specifications, already using the new token architecture (CSS variables). Some changes have been made to the component:
h6and6.Breaking changes
weightvalues have changed:'default' | 'regular' | 'light'.Additional context
Figma designs