Skip to content

build: upgrade Go from 1.21 to 1.24#70

Draft
ad-0xpp wants to merge 6 commits intodydx-fork-v0.50.5from
upgrade-go-1.24
Draft

build: upgrade Go from 1.21 to 1.24#70
ad-0xpp wants to merge 6 commits intodydx-fork-v0.50.5from
upgrade-go-1.24

Conversation

@ad-0xpp
Copy link

@ad-0xpp ad-0xpp commented Jul 21, 2025

  • Upgrade Go version from 1.21 to 1.24
  • Resolve non-constant format strings in error wrapping functions
  • Update Ledger-related test to skip when hardware is unavailable

Modules changed:-

  • x/auth, x/distribution, x/authz, x/gov, x/group

  • crypto/hd, crypto/ledger, types/bech32

  • Feature (Go version upgrade)

  • Test improvements

Closes: ENG-193

@linear
Copy link

linear bot commented Jul 21, 2025

ad-0xpp added 6 commits July 23, 2025 13:02
…ility

- Update cosmossdk.io/x/tx from v0.13.1 to v0.13.7
- Fixes GO-2024-3339: Transaction decoding stack overflow vulnerability
- Minimal change: single dependency version update
- All vulnerabilities resolved with Go 1.24.5 toolchain
- Fix unique index constraint violation in deterministic tests
- Improve account number generation to avoid conflicts across test runs
- Add proper cleanup to remove accounts after each test iteration
- Increase base offset from 1000 to 100000 for better separation
- Add per-account offset to ensure uniqueness within test runs
- Add conflict detection and cleanup for existing accounts

Fixes: collections: conflict: index uniqueness constrain violation: 59000
- Update go.mod from go 1.21 to go 1.24
- Update all CI/CD workflow files to use Go 1.24
- Go 1.24.5 toolchain automatically resolves most vulnerabilities
- No code changes required - backward compatible upgrade
- Verified: builds successfully and passes vulnerability scan

This minimal change provides maximum security benefit with minimal risk.
…4-3339 vulnerability

- Update cosmossdk.io/x/tx from v0.13.1 to v0.13.7 in 9 sub-modules
- Fixes the critical GO-2024-3339 vulnerability in transaction decoding
- Maintains build compatibility - no breaking changes
- Minimal surgical fix targeting only the vulnerable dependency

This addresses the primary security concern while keeping changes minimal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant