Changes to better implement textConnections#11
Open
stranda wants to merge 1 commit intodyerlab:masterfrom
Open
Changes to better implement textConnections#11stranda wants to merge 1 commit intodyerlab:masterfrom
stranda wants to merge 1 commit intodyerlab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added two tests associated with textConnections. I also constructed an "example section"
for read_populations to show how textConnections could be used.
While constructing them, I noticed that missing data in a text connection caused an issue associated with data frame column types (converted int to chr). .read_columns() was changed to convert these columns back to int if a textConnection is involved and if they are not already integer
In the end three files have been changed: read_population.R, read_population.Rd (created by running devtools::document()), and test-read_population.R