Update theme color handling and improve viewport settings for better responsiveness#13
Open
dzhukovsky wants to merge 3 commits into
Open
Update theme color handling and improve viewport settings for better responsiveness#13dzhukovsky wants to merge 3 commits into
dzhukovsky wants to merge 3 commits into
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-wave-0c3faae03-13.westeurope.5.azurestaticapps.net |
… better responsiveness" This reverts commit d71c3d8.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-wave-0c3faae03-13.westeurope.5.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-wave-0c3faae03-13.westeurope.5.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of theme colors and safe area insets to provide a better user experience, especially on devices with notches and when switching between light and dark themes. The most important changes are:
Theme color improvements:
index.htmlto set differenttheme-colormeta tags for light and dark modes using media queries.useThemehook insrc/lib/hooks.tsto dynamically update alltheme-colormeta tags when the theme changes, ensuring the browser UI matches the selected theme.Safe area support:
viewport-fit=coverto the viewport meta tag inindex.htmlto support full-bleed layouts on devices with display notches.SiteHeadercomponent insrc/components/site-header.tsxto add padding usingenv(safe-area-inset-top), preventing content from overlapping with device notches.