Fix error when previewing evaluations with undecided main language#2556
Fix error when previewing evaluations with undecided main language#2556Jakobus400 wants to merge 10 commits into
Conversation
niklasmohrin
left a comment
There was a problem hiding this comment.
we also still need a test that checks that accessing the page works :)
|
one more thing: the magic "fix #..." line should be in the PR description, not the PR title or commit message. You can still change this, and then you will see that this PR will be automatically linked to the issue in the "Development" section on the right of the page. |
niklasmohrin
left a comment
There was a problem hiding this comment.
code looks good, but still needs tests
|
Hi @Jakobus400, do you want to continue with this or should we take over? |
niklasmohrin
left a comment
There was a problem hiding this comment.
I agree with Richard. Other than that, I have one small suggestion. Thanks!
|
Ah, our linter now complains that the function has too many local variables. I think for this PR it is fine to disable this lint in this function. You can put a |
504bd99 to
63149bd
Compare
#2555 Preview of evaluation form failed with undecided language. Fixed by checking in render_vote_page()