More types: Part 1#2720
Merged
richardebeling merged 3 commits intoMay 11, 2026
Merged
Conversation
Member
Author
|
@niklasmohrin these non-cherrypicked changes were necessary to make precommit pass: 9c9b32e |
niklasmohrin
approved these changes
May 4, 2026
| default_sheet_name = _("Redemptions") | ||
|
|
||
| def export_impl(self, users_with_redeemed_points): # pylint: disable=arguments-differ | ||
| def export_impl(self, users_with_redeemed_points: Iterable) -> None: # pylint: disable=arguments-differ |
Member
There was a problem hiding this comment.
Suggested change
| def export_impl(self, users_with_redeemed_points: Iterable) -> None: # pylint: disable=arguments-differ | |
| def export_impl(self, users_with_redeemed_points: Iterable[UserProfile]) -> None: # pylint: disable=arguments-differ |
Member
Author
There was a problem hiding this comment.
Sadly doesn't work because we access user.points below and that is just a monkey-annotated field
richardebeling
force-pushed
the
types-subchanges1
branch
from
cfaa62d to
913b88d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset of changes from #2687 for simpler review