Optimize question migration#2722
Open
Kakadus wants to merge 1 commit into
Open
Conversation
| .distinct("text_de", "text_en", "allows_additional_textanswers", "type") | ||
| .iterator() | ||
| ), | ||
| batch_size=2000, |
Member
There was a problem hiding this comment.
Let's not do hasty changes to code for issues we don't fully understand. @janno42 do we have a specific understanding what part of this migration is problematic?
I would like to first have some test data for which we can reproduce the issue, and then properly check that a change here actually solves the issue. My mental model is that we have hundreds of questionnaires and maybe ten thousands of questions in production. This should be in the range of megabytes of data. We should easily be able to load those model instances, especially if no related models are ever loaded/accessed.
I could see that we have more answers than fit in memory, then we should do a targeted fix for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redesign evaluation 0161 and 0162 migration so that all question objects are not stored in python.
batch_size2000 on plain querysets onlyfollowup for #2513