Update grades_-/staff_semester_view to css grid#2748
Draft
fekoch wants to merge 1 commit into
Draft
Conversation
fekoch
changed the title
Refactors the DataGrid class to provide different factory functions for different HTML representations of the tables. Signed-off-by: Felix Koch <dev@felixkoch.at>
Member
|
There are still TODOs in the code. Is there something that we should already look at? |
Collaborator
Author
Good point, I overlooked those. Something, something self review.... Still, @niklasmohrin I would appreciate a review. Resolving the TODOs should only result in a minimal diff. (I switched it to draft anyway.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the DataGrid class to provide different factory functions for different HTML representations of the tables.
Updates the tables in:
grades_semester_view.htmlstaff_semester_view.html