Skip to content

fix duplicate dependency analysis for workspace links#201

Open
tristanmanchester wants to merge 1 commit intoe18e:mainfrom
tristanmanchester:codex/fix-workspace-link-duplicate-analysis
Open

fix duplicate dependency analysis for workspace links#201
tristanmanchester wants to merge 1 commit intoe18e:mainfrom
tristanmanchester:codex/fix-workspace-link-duplicate-analysis

Conversation

@tristanmanchester
Copy link
Copy Markdown

Summary

  • ignore lockfile package entries that do not have a resolved version during duplicate dependency analysis
  • add a regression test covering npm workspace link entries in package-lock data

Root cause

npm workspaces can appear in package-lock parsing as linked packages without a version. The duplicate dependency analyzer treated every package entry as a concrete installed version and passed an undefined version string into node:util styleText, which crashed analysis on Node 24.

Validation

  • npm test -- src/test/duplicate-dependencies.test.ts
  • npm run build
  • linked the patched CLI into /Users/tristan/Projects/react-native-dotgrid and verified analyze now completes instead of crashing

@tristanmanchester tristanmanchester marked this pull request as ready for review March 31, 2026 14:57
@tristanmanchester tristanmanchester changed the title [codex] fix duplicate dependency analysis for workspace links fix duplicate dependency analysis for workspace links Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant