[prefer-spread-syntax] Fix bug: Object.assign({}, ...arrOfObjs) incorrectly auto-fixed#91
Merged
[prefer-spread-syntax] Fix bug: Object.assign({}, ...arrOfObjs) incorrectly auto-fixed#91
Conversation
gameroman
approved these changes
Mar 23, 2026
43081j
approved these changes
Mar 23, 2026
Contributor
|
This is the correct way to fix it 👍 thanks for the PR and good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes ``Object.assign({}, ...myArrOfObjects)` to be treated as valid syntax as it cannot be easily fixed/replaced.
Usecase for this is collecting patches as an array and then applying all of them at a time
The easiest way (I can think of) to perform this without Object.assign() would be using many spreads in a reduce
But from my basic grasp of eslint fixers, that would be complicated to support, especially since it can be
Object.assign({}, ...arr, another, ...arr2)and so on.This fixes #89